Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: ActionSheet): fix when no title or message would not show blank on header #192

Merged
merged 5 commits into from
Dec 25, 2018

Conversation

Guoyuanqiang
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Dec 25, 2018

Codecov Report

Merging #192 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
- Coverage   86.24%   86.22%   -0.03%     
==========================================
  Files         222      222              
  Lines        7156     7158       +2     
  Branches     1002     1003       +1     
==========================================
  Hits         6172     6172              
- Misses        587      588       +1     
- Partials      397      398       +1
Impacted Files Coverage Δ
components/action-sheet/action-sheet.component.ts 79.16% <100%> (-7.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23f36c1...5752715. Read the comment docs.

@fisherspy fisherspy self-requested a review December 25, 2018 07:35
@Guoyuanqiang
Copy link
Member Author

close #172

@fisherspy fisherspy merged commit b0f41b7 into NG-ZORRO:master Dec 25, 2018
@Guoyuanqiang Guoyuanqiang deleted the actionsheet branch December 29, 2018 03:31
fisherspy pushed a commit that referenced this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants