Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:modal): feat add modal closable and maskClosable demo #195

Merged
merged 3 commits into from
Dec 25, 2018

Conversation

Guoyuanqiang
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Dec 25, 2018

Codecov Report

Merging #195 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
- Coverage   86.26%   86.25%   -0.01%     
==========================================
  Files         222      222              
  Lines        7163     7161       -2     
  Branches     1003     1003              
==========================================
- Hits         6179     6177       -2     
  Misses        586      586              
  Partials      398      398
Impacted Files Coverage Δ
components/modal/modal.component.ts 72.65% <0%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0759f65...97e70d3. Read the comment docs.

@fisherspy fisherspy merged commit d3d3478 into NG-ZORRO:master Dec 25, 2018
@Guoyuanqiang Guoyuanqiang deleted the modal-click branch December 29, 2018 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants