Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: input-item): fix input-item value protect #196

Merged
merged 2 commits into from
Dec 26, 2018
Merged

fix(module: input-item): fix input-item value protect #196

merged 2 commits into from
Dec 26, 2018

Conversation

nuonuoge
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Dec 25, 2018

Codecov Report

Merging #196 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #196      +/-   ##
=========================================
- Coverage   86.33%   86.3%   -0.03%     
=========================================
  Files         222     222              
  Lines        7162    7162              
  Branches     1003    1003              
=========================================
- Hits         6183    6181       -2     
- Misses        583     584       +1     
- Partials      396     397       +1
Impacted Files Coverage Δ
components/input-item/input-item.component.ts 95.18% <100%> (ø) ⬆️
.../input-item/custom-input/custom-input.component.ts 90.84% <0%> (-1.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2c0157...a19c7a3. Read the comment docs.

@fisherspy fisherspy merged commit 883c2ba into NG-ZORRO:master Dec 26, 2018
@nuonuoge nuonuoge deleted the fix-input-item branch December 26, 2018 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants