Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: pulltorefresh): feat support scrollendrefresh and support both up and down #204

Merged
merged 3 commits into from
Dec 29, 2018

Conversation

Guoyuanqiang
Copy link
Member

…t both up and down

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Dec 28, 2018

Codecov Report

Merging #204 into master will decrease coverage by 0.21%.
The diff coverage is 63.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
- Coverage   86.46%   86.25%   -0.22%     
==========================================
  Files         224      224              
  Lines        7204     7251      +47     
  Branches     1008     1019      +11     
==========================================
+ Hits         6229     6254      +25     
- Misses        573      589      +16     
- Partials      402      408       +6
Impacted Files Coverage Δ
...mponents/pull-to-refresh/pull-to-refresh.module.ts 100% <100%> (ø) ⬆️
...nents/pull-to-refresh/pull-to-refresh.component.ts 77.07% <62.66%> (-10.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3db39ae...10e0dc4. Read the comment docs.

Copy link
Collaborator

@fisherspy fisherspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

   private _onChanged: (value: object) => {};
   private _onTouched: () => {};

change to

 private _ngModelOnChange: (value: object) => {};

 private _ngModelOnTouched: () => {};

@fisherspy fisherspy merged commit 149c461 into NG-ZORRO:master Dec 29, 2018
@Guoyuanqiang Guoyuanqiang deleted the pulltorefresh branch December 29, 2018 03:31
fisherspy pushed a commit that referenced this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants