Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(showcase): fix website icon show error bug #214

Merged
merged 1 commit into from
Jan 2, 2019

Conversation

3fuyu
Copy link
Contributor

@3fuyu 3fuyu commented Jan 2, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@3fuyu 3fuyu requested a review from fisherspy January 2, 2019 09:36
@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #214 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #214   +/-   ##
=======================================
  Coverage   86.25%   86.25%           
=======================================
  Files         224      224           
  Lines        7311     7311           
  Branches     1029     1029           
=======================================
  Hits         6306     6306           
  Misses        600      600           
  Partials      405      405

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b53ff31...1463335. Read the comment docs.

@fisherspy fisherspy merged commit bfe2b3d into NG-ZORRO:master Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants