Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: calendar): fix timepicker select error #216

Merged
merged 3 commits into from
Jan 4, 2019
Merged

fix(module: calendar): fix timepicker select error #216

merged 3 commits into from
Jan 4, 2019

Conversation

nuonuoge
Copy link
Collaborator

@nuonuoge nuonuoge commented Jan 2, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #216 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #216     +/-   ##
=========================================
+ Coverage   86.25%   86.45%   +0.2%     
=========================================
  Files         224      224             
  Lines        7311     7311             
  Branches     1029     1029             
=========================================
+ Hits         6306     6321     +15     
+ Misses        600      587     -13     
+ Partials      405      403      -2
Impacted Files Coverage Δ
...onents/calendar/timepicker/timepicker.component.ts 79.54% <100%> (+4.54%) ⬆️
components/calendar/calendar.component.ts 71.42% <0%> (+0.95%) ⬆️
...nts/date-picker-view/date-picker-view.component.ts 92% <0%> (+1.33%) ⬆️
components/date-picker/date-picker.component.ts 75.1% <0%> (+2.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec88d97...28e7947. Read the comment docs.

@fisherspy fisherspy requested review from 3fuyu and removed request for Guoyuanqiang January 3, 2019 03:31
@3fuyu 3fuyu merged commit 03ffa9e into NG-ZORRO:master Jan 4, 2019
@3fuyu
Copy link
Contributor

3fuyu commented Jan 4, 2019

#212

@nuonuoge nuonuoge deleted the fixcalendar branch January 12, 2019 12:33
fisherspy pushed a commit that referenced this pull request Mar 10, 2020
* fix(module: calendar): fix timepicker select error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants