Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: modal): fix no actions would work error. #222

Merged
merged 5 commits into from
Jan 8, 2019

Conversation

Guoyuanqiang
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@fisherspy fisherspy self-requested a review January 7, 2019 11:54
@codecov
Copy link

codecov bot commented Jan 7, 2019

Codecov Report

Merging #222 into master will increase coverage by 0.05%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   86.45%   86.51%   +0.05%     
==========================================
  Files         224      224              
  Lines        7308     7303       -5     
  Branches     1029     1023       -6     
==========================================
  Hits         6318     6318              
  Misses        587      587              
+ Partials      403      398       -5
Impacted Files Coverage Δ
components/modal/modal.service.ts 69.14% <50%> (+3.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dae0737...a1a813d. Read the comment docs.

@fisherspy fisherspy merged commit 25b7aec into NG-ZORRO:master Jan 8, 2019
@Guoyuanqiang Guoyuanqiang deleted the modal branch January 10, 2019 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants