Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: actionsheet): fix actionsheet not destory unsubscribe for locale #236

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Guoyuanqiang
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jan 10, 2019

Codecov Report

Merging #236 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
+ Coverage   86.64%   86.64%   +<.01%     
==========================================
  Files         229      229              
  Lines        7322     7325       +3     
  Branches     1031     1031              
==========================================
+ Hits         6344     6347       +3     
  Misses        573      573              
  Partials      405      405
Impacted Files Coverage Δ
components/action-sheet/action-sheet.component.ts 80.55% <100%> (+1.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65ad469...942a62e. Read the comment docs.

@3fuyu 3fuyu merged commit d719496 into NG-ZORRO:master Jan 10, 2019
@Guoyuanqiang Guoyuanqiang deleted the actionsheet branch January 10, 2019 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants