Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:pulltorefresh): fix when up pull, then down pull, emit ref… #248

Merged
merged 2 commits into from
Jan 15, 2019
Merged

fix(module:pulltorefresh): fix when up pull, then down pull, emit ref… #248

merged 2 commits into from
Jan 15, 2019

Conversation

nuonuoge
Copy link
Collaborator

…resh error

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jan 15, 2019

Codecov Report

Merging #248 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
- Coverage    86.8%   86.77%   -0.03%     
==========================================
  Files         229      229              
  Lines        7344     7344              
  Branches     1037     1037              
==========================================
- Hits         6375     6373       -2     
- Misses        565      566       +1     
- Partials      404      405       +1
Impacted Files Coverage Δ
...nents/pull-to-refresh/pull-to-refresh.component.ts 72.12% <0%> (-1.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f82b7dd...e5c6776. Read the comment docs.

@Guoyuanqiang
Copy link
Member

close #244

@Guoyuanqiang Guoyuanqiang merged commit 5fd57d7 into NG-ZORRO:master Jan 15, 2019
@nuonuoge nuonuoge deleted the pull-to-refresh branch January 19, 2019 06:39
fisherspy pushed a commit that referenced this pull request Mar 10, 2020
…resh error (#248)

* fix(module:pulltorefresh): fix when up pull, then down pull, emit refresh error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants