Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: grid): support custom icon and local assets #257

Merged
merged 2 commits into from
Jan 21, 2019

Conversation

Guoyuanqiang
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Jan 20, 2019

Codecov Report

Merging #257 into master will decrease coverage by <.01%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
- Coverage   86.78%   86.77%   -0.01%     
==========================================
  Files         229      229              
  Lines        7353     7356       +3     
  Branches     1038     1040       +2     
==========================================
+ Hits         6381     6383       +2     
- Misses        567      568       +1     
  Partials      405      405
Impacted Files Coverage Δ
components/grid/grid.module.ts 100% <100%> (ø) ⬆️
components/grid/grid.component.ts 88.75% <50%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f5fc79...8182362. Read the comment docs.

@fisherspy fisherspy self-requested a review January 21, 2019 08:47
@Guoyuanqiang Guoyuanqiang merged commit eafe8ec into NG-ZORRO:master Jan 21, 2019
@Guoyuanqiang Guoyuanqiang deleted the grid branch January 24, 2019 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants