Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): fix not use onOk the next time show error #258

Merged
merged 1 commit into from
Jan 21, 2019
Merged

fix(module:date-picker): fix not use onOk the next time show error #258

merged 1 commit into from
Jan 21, 2019

Conversation

nuonuoge
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jan 20, 2019

Codecov Report

Merging #258 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
- Coverage   86.79%   86.78%   -0.02%     
==========================================
  Files         229      229              
  Lines        7352     7353       +1     
  Branches     1038     1038              
==========================================
  Hits         6381     6381              
- Misses        566      567       +1     
  Partials      405      405
Impacted Files Coverage Δ
components/date-picker/date-picker.directive.ts 92.3% <0%> (-1.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41f20f5...f5e35e1. Read the comment docs.

@Guoyuanqiang Guoyuanqiang merged commit 2f5fc79 into NG-ZORRO:master Jan 21, 2019
@nuonuoge
Copy link
Collaborator Author

在不使用ondismiss和onok时,只使用ngmodel双向绑定时,选中某一时间后,再次打开返显不正确

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants