Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module: picker): perf delete default data in component. #272

Merged
merged 5 commits into from
Jan 31, 2019

Conversation

Guoyuanqiang
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #272 into master will decrease coverage by 0.04%.
The diff coverage is 70.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
- Coverage    86.5%   86.46%   -0.05%     
==========================================
  Files         229      228       -1     
  Lines        7374     7401      +27     
  Branches     1053     1063      +10     
==========================================
+ Hits         6379     6399      +20     
- Misses        584      589       +5     
- Partials      411      413       +2
Impacted Files Coverage Δ
components/picker/picker.directive.ts 88.88% <64.7%> (-4.54%) ⬇️
components/picker/picker.component.ts 71.13% <72.22%> (+1.08%) ⬆️
components/picker-view/picker-view.component.ts 94.59% <75%> (-5.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8759db0...7f33307. Read the comment docs.

@fisherspy fisherspy merged commit ec748c3 into NG-ZORRO:master Jan 31, 2019
@Guoyuanqiang Guoyuanqiang deleted the picker branch January 31, 2019 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants