Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: carousel): fix carousel detect height change need to init carouseItem #290

Merged
merged 1 commit into from
Feb 21, 2019

Conversation

Guoyuanqiang
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #290 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
- Coverage   89.96%   89.95%   -0.02%     
==========================================
  Files         228      228              
  Lines        6819     6820       +1     
  Branches      550      550              
==========================================
  Hits         6135     6135              
- Misses        521      522       +1     
  Partials      163      163
Impacted Files Coverage Δ
components/carousel/carousel.component.ts 76.98% <0%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e251652...d5e37da. Read the comment docs.

@fisherspy fisherspy merged commit 86be97d into NG-ZORRO:master Feb 21, 2019
@Guoyuanqiang Guoyuanqiang deleted the carousel branch March 14, 2019 15:06
fisherspy pushed a commit that referenced this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants