Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: inputitem): fix inputitem onChange does not trigger when … #299

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

sWhite01111
Copy link
Contributor

…typing Chinese characters

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #299 into master will decrease coverage by 0.02%.
The diff coverage is 91.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #299      +/-   ##
=========================================
- Coverage   89.92%   89.9%   -0.03%     
=========================================
  Files         228     228              
  Lines        6831    6832       +1     
  Branches      551     551              
=========================================
- Hits         6143    6142       -1     
- Misses        525     526       +1     
- Partials      163     164       +1
Impacted Files Coverage Δ
components/input-item/input-item.component.ts 98.35% <91.3%> (-1.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ed613e...e1ac47a. Read the comment docs.

@Guoyuanqiang Guoyuanqiang self-requested a review February 27, 2019 02:45
@Guoyuanqiang
Copy link
Member

close #291

@Guoyuanqiang Guoyuanqiang merged commit e7a925d into NG-ZORRO:master Feb 27, 2019
fisherspy pushed a commit that referenced this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants