Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: drawer): synchronize code and documentation #311

Merged
merged 2 commits into from
Feb 28, 2019

Conversation

BronzeCui
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #311 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
+ Coverage   89.59%   89.65%   +0.05%     
==========================================
  Files         229      229              
  Lines        6864     6864              
  Branches      560      560              
==========================================
+ Hits         6150     6154       +4     
+ Misses        550      546       -4     
  Partials      164      164
Impacted Files Coverage Δ
components/drawer/drawer.component.ts 92% <100%> (ø) ⬆️
components/picker/picker.component.ts 82.35% <0%> (+1.76%) ⬆️
components/picker/picker.service.ts 94.44% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58e88ca...5a81988. Read the comment docs.

@Guoyuanqiang
Copy link
Member

close #309

@fisherspy fisherspy merged commit 1d53a15 into NG-ZORRO:master Feb 28, 2019
@BronzeCui BronzeCui deleted the fix-branch branch June 11, 2019 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants