Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: list): renderHeader&renderFooter support String and Temp… #313

Merged
merged 2 commits into from
Mar 1, 2019

Conversation

3fuyu
Copy link
Contributor

@3fuyu 3fuyu commented Mar 1, 2019

…lateRef

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@3fuyu 3fuyu requested a review from fisherspy March 1, 2019 07:48
@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #313 into master will increase coverage by 0.05%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
+ Coverage   89.59%   89.65%   +0.05%     
==========================================
  Files         229      229              
  Lines        6864     6871       +7     
  Branches      560      560              
==========================================
+ Hits         6150     6160      +10     
+ Misses        550      548       -2     
+ Partials      164      163       -1
Impacted Files Coverage Δ
components/list/list.component.ts 91.66% <75%> (-8.34%) ⬇️
components/date-picker/date-picker.component.ts 79.86% <0%> (+0.23%) ⬆️
components/picker/picker.component.ts 82.35% <0%> (+1.76%) ⬆️
components/picker/picker.service.ts 94.44% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d53a15...5722999. Read the comment docs.

@fisherspy fisherspy merged commit 546b38d into NG-ZORRO:master Mar 1, 2019
@3fuyu
Copy link
Contributor Author

3fuyu commented Mar 1, 2019

#304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants