Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: textarea-item): fix textarea-item value protect #331

Merged
merged 2 commits into from
Mar 12, 2019
Merged

fix(module: textarea-item): fix textarea-item value protect #331

merged 2 commits into from
Mar 12, 2019

Conversation

nuonuoge
Copy link
Collaborator

@nuonuoge nuonuoge commented Mar 8, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #331 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
+ Coverage   89.58%   89.61%   +0.02%     
==========================================
  Files         229      229              
  Lines        6873     6882       +9     
  Branches      561      563       +2     
==========================================
+ Hits         6157     6167      +10     
+ Misses        552      550       -2     
- Partials      164      165       +1
Impacted Files Coverage Δ
...omponents/textarea-item/textarea-item.component.ts 98.64% <100%> (ø) ⬆️
components/core/services/popup.service.ts 80.48% <0%> (-3.89%) ⬇️
components/picker/picker.component.ts 82.35% <0%> (+1.76%) ⬆️
components/picker/picker.service.ts 94.44% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b69ee5a...de0d6be. Read the comment docs.

@nuonuoge
Copy link
Collaborator Author

@sWhite01111
Copy link
Contributor

恩 我没有仔细看,前面加typeof是对的

@fisherspy fisherspy merged commit ffe4f8d into NG-ZORRO:master Mar 12, 2019
@nuonuoge nuonuoge deleted the fixtextarea branch March 20, 2019 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants