Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: popupservice): fix popupservice get component name with build prod runtime error #333

Merged
merged 1 commit into from
Mar 12, 2019

Conversation

Guoyuanqiang
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@Guoyuanqiang
Copy link
Member Author

close #332

@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #333 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
- Coverage   89.63%   89.58%   -0.06%     
==========================================
  Files         229      229              
  Lines        6872     6873       +1     
  Branches      561      561              
==========================================
- Hits         6160     6157       -3     
- Misses        548      552       +4     
  Partials      164      164
Impacted Files Coverage Δ
components/modal/modal.service.ts 70.45% <100%> (ø) ⬆️
components/core/services/popup.service.ts 84.37% <100%> (+0.5%) ⬆️
components/action-sheet/action-sheet.service.ts 84.31% <100%> (ø) ⬆️
components/picker/picker.service.ts 88.88% <100%> (-5.56%) ⬇️
components/picker/picker.component.ts 80.58% <0%> (-1.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd88a52...a20de41. Read the comment docs.

@fisherspy fisherspy merged commit b69ee5a into NG-ZORRO:master Mar 12, 2019
@Guoyuanqiang Guoyuanqiang deleted the picker branch March 14, 2019 15:06
fisherspy pushed a commit that referenced this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants