Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (module: tabbar): fix tabbar set activeTab not work and add demo #345

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

Guoyuanqiang
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #345 into master will decrease coverage by 0.07%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
- Coverage   89.64%   89.56%   -0.08%     
==========================================
  Files         229      229              
  Lines        6873     6878       +5     
  Branches      561      562       +1     
==========================================
- Hits         6161     6160       -1     
- Misses        548      553       +5     
- Partials      164      165       +1
Impacted Files Coverage Δ
components/tab-bar/tab-bar.component.ts 84.31% <66.66%> (-2.65%) ⬇️
components/picker/picker.service.ts 88.88% <0%> (-5.56%) ⬇️
components/picker/picker.component.ts 80.58% <0%> (-1.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36e5410...83f7b40. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants