Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module: modal): perf modal import CoreModule. #348

Merged
merged 1 commit into from
Mar 20, 2019

Conversation

Guoyuanqiang
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #348 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #348      +/-   ##
=========================================
+ Coverage   89.54%   89.6%   +0.05%     
=========================================
  Files         229     229              
  Lines        6879    6880       +1     
  Branches      563     563              
=========================================
+ Hits         6160    6165       +5     
+ Misses        554     550       -4     
  Partials      165     165
Impacted Files Coverage Δ
components/modal/modal.module.ts 100% <100%> (ø) ⬆️
components/picker/picker.component.ts 81.97% <0%> (+1.74%) ⬆️
components/picker/picker.service.ts 94.44% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbcc0cf...10eda65. Read the comment docs.

@fisherspy fisherspy merged commit a3b9014 into NG-ZORRO:master Mar 20, 2019
@Guoyuanqiang Guoyuanqiang deleted the modal branch April 9, 2019 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants