Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: carousel): feat carousel support dragging #350

Merged
merged 4 commits into from
Mar 20, 2019

Conversation

Guoyuanqiang
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@Guoyuanqiang
Copy link
Member Author

close #349

@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #350 into master will decrease coverage by 0.04%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #350      +/-   ##
==========================================
- Coverage    89.6%   89.56%   -0.05%     
==========================================
  Files         229      229              
  Lines        6880     6880              
  Branches      563      563              
==========================================
- Hits         6165     6162       -3     
- Misses        550      554       +4     
+ Partials      165      164       -1
Impacted Files Coverage Δ
components/carousel/carousel.component.ts 77.07% <80%> (+0.39%) ⬆️
components/picker/picker.service.ts 88.88% <0%> (-5.56%) ⬇️
components/picker/picker.component.ts 80.23% <0%> (-1.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3b9014...c3e5dd7. Read the comment docs.

@fisherspy fisherspy merged commit 5dc49a4 into NG-ZORRO:master Mar 20, 2019
@Guoyuanqiang Guoyuanqiang deleted the carousel branch April 9, 2019 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants