Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: nav-bar): add icon string support #38

Merged
merged 2 commits into from
Oct 12, 2018
Merged

feat(module: nav-bar): add icon string support #38

merged 2 commits into from
Oct 12, 2018

Conversation

nuonuoge
Copy link
Collaborator

@nuonuoge nuonuoge commented Oct 12, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Oct 12, 2018

Codecov Report

Merging #38 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage    85.9%   85.91%   +0.01%     
==========================================
  Files         209      209              
  Lines        6889     6894       +5     
  Branches      977      978       +1     
==========================================
+ Hits         5918     5923       +5     
  Misses        559      559              
  Partials      412      412
Impacted Files Coverage Δ
components/nav-bar/nav-bar.module.ts 100% <100%> (ø) ⬆️
components/nav-bar/nav-bar.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0720fdc...12fd7ab. Read the comment docs.

Copy link
Contributor

@3fuyu 3fuyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your work is hard ! I want to discuss some detail with you, can you join us dingtalk group?
image

@nuonuoge
Copy link
Collaborator Author

Only group owners can add group members, number: nuonuo66

@3fuyu 3fuyu merged commit 4a89b0c into NG-ZORRO:master Oct 12, 2018
fisherspy pushed a commit that referenced this pull request Mar 10, 2020
* feat(module: nav-bar): add icon string support

* feat(module: nav-bar): add icon string support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants