Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: all): export components API publicly #389

Merged
merged 3 commits into from
Apr 23, 2019

Conversation

fisherspy
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[x] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@fisherspy fisherspy requested review from Guoyuanqiang, 3fuyu, BronzeCui and sWhite01111 and removed request for Guoyuanqiang April 19, 2019 09:08
@codecov
Copy link

codecov bot commented Apr 19, 2019

Codecov Report

Merging #389 into master will increase coverage by 0.06%.
The diff coverage is 99.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
+ Coverage   89.25%   89.31%   +0.06%     
==========================================
  Files         229      320      +91     
  Lines        6903     7093     +190     
  Branches      564      568       +4     
==========================================
+ Hits         6161     6335     +174     
- Misses        571      587      +16     
  Partials      171      171
Impacted Files Coverage Δ
...onents/date-picker/date-picker-options.provider.ts 100% <ø> (ø) ⬆️
components/checkbox/agree-item.component.ts 100% <ø> (ø) ⬆️
components/locale-provider/locale/sv_SE.ts 100% <ø> (ø)
components/radio/radio.component.ts 100% <ø> (ø) ⬆️
components/locale-provider/locale/en_US.ts 100% <ø> (ø)
components/checkbox/checkbox-item.component.ts 88.88% <ø> (ø) ⬆️
components/locale-provider/locale/ru_RU.ts 100% <ø> (ø)
components/locale-provider/locale/zh_CN.ts 100% <ø> (ø)
components/locale-provider/locale/da_DK.ts 100% <ø> (ø)
components/activity-indicator/index.ts 100% <100%> (ø)
... and 204 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c3ad0f...4b14824. Read the comment docs.

Copy link
Contributor

@BronzeCui BronzeCui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Contributor

@BronzeCui BronzeCui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants