Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: tabs&tabbar): tabs&tabbar refactor #399

Merged
merged 16 commits into from Apr 29, 2019

Conversation

fisherspy
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

TabBar APIs have been changed to make it more simple.

Other information

@codecov
Copy link

codecov bot commented Apr 28, 2019

Codecov Report

Merging #399 into master will decrease coverage by 0.21%.
The diff coverage is 75.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #399      +/-   ##
==========================================
- Coverage   89.36%   89.15%   -0.22%     
==========================================
  Files         320      321       +1     
  Lines        7093     7080      -13     
  Branches      568      582      +14     
==========================================
- Hits         6339     6312      -27     
- Misses        583      589       +6     
- Partials      171      179       +8
Impacted Files Coverage Δ
components/tab-bar/public-api.ts 100% <ø> (ø) ⬆️
components/tabs/tab-pane-body.component.ts 100% <100%> (ø)
components/tab-bar/tab-bar-item.component.ts 100% <100%> (ø)
components/tabs/tab-pane.component.ts 100% <100%> (ø) ⬆️
components/tabs/public-api.ts 100% <100%> (ø) ⬆️
components/tabs/tabs.module.ts 100% <100%> (ø) ⬆️
components/tab-bar/tab-bar.module.ts 100% <100%> (ø) ⬆️
components/tabs/default-tab-bar.component.ts 85.04% <54.28%> (-10.61%) ⬇️
components/tab-bar/tab-bar.component.ts 76.74% <61.9%> (-7.57%) ⬇️
components/tabs/tabs.component.ts 95.74% <84.61%> (-0.34%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80bd1b5...c3df696. Read the comment docs.

Copy link
Contributor

@BronzeCui BronzeCui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. action-sheet 修改另外提交分支
  2. tabs.component.spec.ts 中注释测试用例对应修改或删除
  3. 目前api与react仍未保持一致,请再次确认,因涉及breakchange,不建议重复修改

Copy link
Contributor

@BronzeCui BronzeCui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@fisherspy fisherspy merged commit f82ceab into NG-ZORRO:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants