Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: stepper): fixed stepper disabled bug #405

Merged
merged 3 commits into from
Apr 30, 2019

Conversation

sWhite01111
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@sWhite01111 sWhite01111 mentioned this pull request Apr 29, 2019
Copy link
Contributor

@Anberm Anberm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not in favor of such a modification. In disable true to false, input still cannot be input. Similarly, disable value does not need to be determined in ngOnChanges, because this time it does not affect _upDisabled & _downDIsabled

@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #405 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   89.14%   89.15%   +<.01%     
==========================================
  Files         321      321              
  Lines        7087     7089       +2     
  Branches      582      584       +2     
==========================================
+ Hits         6318     6320       +2     
  Misses        590      590              
  Partials      179      179
Impacted Files Coverage Δ
components/stepper/stepper.component.ts 97.47% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1db49eb...1778932. Read the comment docs.

@fisherspy fisherspy merged commit acb2a95 into NG-ZORRO:master Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants