Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: checkboxitem&radioitem): support wrap API #406

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

fisherspy
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #406 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
+ Coverage   89.09%   89.15%   +0.05%     
==========================================
  Files         321      321              
  Lines        7080     7082       +2     
  Branches      582      582              
==========================================
+ Hits         6308     6314       +6     
+ Misses        593      589       -4     
  Partials      179      179
Impacted Files Coverage Δ
components/checkbox/checkbox-item.component.ts 89.28% <100%> (+0.39%) ⬆️
components/radio/radio-item.component.ts 91.3% <100%> (+0.39%) ⬆️
components/picker/picker.component.ts 81.97% <0%> (+1.74%) ⬆️
components/picker/picker.service.ts 94.44% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c39051...909d941. Read the comment docs.

@fisherspy fisherspy merged commit db8a6c8 into NG-ZORRO:master Apr 29, 2019
Copy link
Contributor

@BronzeCui BronzeCui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

添加实现即可,文档没有必要修改,文档中提到“基于ListItem对Radio进行封装,ListItem的extra属性固定传入Radio,其他属性和ListItem一致。”

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants