Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module: tabs&tabbar): change prerenderingSiblingsNumber to -1 by… #407

Merged
merged 3 commits into from
Apr 30, 2019

Conversation

fisherspy
Copy link
Collaborator

… default

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #407 into master will decrease coverage by <.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
- Coverage   89.15%   89.14%   -0.01%     
==========================================
  Files         321      321              
  Lines        7082     7087       +5     
  Branches      582      582              
==========================================
+ Hits         6314     6318       +4     
- Misses        589      590       +1     
  Partials      179      179
Impacted Files Coverage Δ
components/tab-bar/tab-bar.component.ts 76.74% <100%> (ø) ⬆️
components/tabs/tabs.component.ts 95.74% <100%> (ø) ⬆️
components/tabs/tab-pane-body.component.ts 94.11% <83.33%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db8a6c8...e855b5e. Read the comment docs.

Copy link
Contributor

@BronzeCui BronzeCui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@fisherspy fisherspy merged commit 1db49eb into NG-ZORRO:master Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants