Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:toast): provides a way for angular new API to self-inject #426

Merged
merged 8 commits into from
May 7, 2019

Conversation

DreamPWJ
Copy link
Contributor

@DreamPWJ DreamPWJ commented May 7, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

Merging #426 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
+ Coverage   85.74%   85.79%   +0.05%     
==========================================
  Files         321      321              
  Lines        7722     7722              
  Branches     1097     1097              
==========================================
+ Hits         6621     6625       +4     
+ Misses        665      659       -6     
- Partials      436      438       +2
Impacted Files Coverage Δ
components/toast/toast.service.ts 94.11% <ø> (ø) ⬆️
components/picker/picker.component.ts 69.69% <0%> (+1.51%) ⬆️
components/picker/picker.service.ts 85% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83dbeaa...f4b4a01. Read the comment docs.

@Guoyuanqiang Guoyuanqiang merged commit ad31989 into NG-ZORRO:master May 7, 2019
fisherspy pushed a commit that referenced this pull request Mar 10, 2020
…#426)

* chore: code specification optimization

* docs: update README.md

* feat(module:toast): provides a way for angular new API to self-inject

* Revert "feat(module:toast): provides a way for angular new API to self-inject"

* feat(module:toast): provides a way for angular new API to self-inject
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants