Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: picker): fix picker style error #434

Merged
merged 2 commits into from
May 8, 2019
Merged

fix(module: picker): fix picker style error #434

merged 2 commits into from
May 8, 2019

Conversation

fisherspy
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented May 8, 2019

Codecov Report

Merging #434 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
+ Coverage   85.72%   85.77%   +0.05%     
==========================================
  Files         314      314              
  Lines        7623     7623              
  Branches     1082     1082              
==========================================
+ Hits         6535     6539       +4     
+ Misses        661      655       -6     
- Partials      427      429       +2
Impacted Files Coverage Δ
components/picker/picker.component.ts 69.69% <0%> (+1.51%) ⬆️
components/picker/picker.service.ts 85% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a1f52e...f57d0a8. Read the comment docs.

@fisherspy fisherspy merged commit c09b85e into master May 8, 2019
@fisherspy fisherspy deleted the patch_40 branch May 20, 2019 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants