Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:badge): fix badge when text value form empty to non empty #441

Merged
merged 5 commits into from
May 20, 2019
Merged

fix(module:badge): fix badge when text value form empty to non empty #441

merged 5 commits into from
May 20, 2019

Conversation

nuonuoge
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #441 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
- Coverage   85.62%   85.61%   -0.02%     
==========================================
  Files         270      270              
  Lines        7589     7589              
  Branches     1084     1084              
==========================================
- Hits         6498     6497       -1     
  Misses        662      662              
- Partials      429      430       +1
Impacted Files Coverage Δ
components/badge/badge.component.ts 95.45% <0%> (-1.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02d1ffd...898cda1. Read the comment docs.

@Guoyuanqiang Guoyuanqiang mentioned this pull request May 15, 2019
Copy link
Contributor

@sWhite01111 sWhite01111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#437 the problem still exists

@fisherspy fisherspy merged commit fab7312 into NG-ZORRO:master May 20, 2019
@nuonuoge nuonuoge deleted the fix-badge branch May 20, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants