Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: calendar): fix calendar timepicker display title error bug #444

Merged
merged 1 commit into from
May 16, 2019

Conversation

3fuyu
Copy link
Contributor

@3fuyu 3fuyu commented May 16, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #444 into master will decrease coverage by 0.07%.
The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #444      +/-   ##
=========================================
- Coverage   85.77%   85.7%   -0.08%     
=========================================
  Files         314     314              
  Lines        7623    7631       +8     
  Branches     1082    1084       +2     
=========================================
+ Hits         6539    6540       +1     
- Misses        655     662       +7     
  Partials      429     429
Impacted Files Coverage Δ
components/calendar/util/index.ts 52.38% <12.5%> (-24.55%) ⬇️
components/calendar/calendar.component.ts 71.42% <33.33%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a976c5...68deb2c. Read the comment docs.

@3fuyu 3fuyu merged commit 7ad01ba into NG-ZORRO:master May 16, 2019
@3fuyu
Copy link
Contributor Author

3fuyu commented May 16, 2019

#432

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants