Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: popupservice): set popupservice providers in referenced components. #449

Merged
merged 1 commit into from
May 21, 2019

Conversation

Guoyuanqiang
Copy link
Member

@Guoyuanqiang Guoyuanqiang commented May 21, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented May 21, 2019

Codecov Report

Merging #449 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage    85.6%   85.61%   +<.01%     
==========================================
  Files         270      270              
  Lines        7587     7591       +4     
  Branches     1084     1084              
==========================================
+ Hits         6495     6499       +4     
  Misses        662      662              
  Partials      430      430
Impacted Files Coverage Δ
components/core/services/popup.service.ts 78.78% <ø> (ø) ⬆️
components/modal/modal.module.ts 100% <100%> (ø) ⬆️
components/picker/picker.module.ts 100% <100%> (ø) ⬆️
components/action-sheet/action-sheet.module.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e90387...a6faaf8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants