Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:toast): support position top and bottom #450

Merged
merged 3 commits into from
May 21, 2019
Merged

feat(module:toast): support position top and bottom #450

merged 3 commits into from
May 21, 2019

Conversation

nuonuoge
Copy link
Collaborator

@nuonuoge nuonuoge commented May 21, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented May 21, 2019

Codecov Report

Merging #450 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
+ Coverage   85.56%   85.61%   +0.04%     
==========================================
  Files         270      270              
  Lines        7591     7589       -2     
  Branches     1084     1084              
==========================================
+ Hits         6495     6497       +2     
+ Misses        668      662       -6     
- Partials      428      430       +2
Impacted Files Coverage Δ
components/toast/toast-options.provider.ts 100% <ø> (ø) ⬆️
components/toast/toast.component.ts 100% <100%> (ø) ⬆️
components/toast/toast.service.ts 94.28% <100%> (+0.16%) ⬆️
components/picker/picker.component.ts 69.69% <0%> (+1.51%) ⬆️
components/picker/picker.service.ts 85% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a14ea6b...6633492. Read the comment docs.

Copy link
Collaborator

@fisherspy fisherspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请在addon里复写样式,index.less与React版本需要保持相同

@nuonuoge nuonuoge changed the title fix(module:toast): support position top and bottom feat(module:toast): support position top and bottom May 21, 2019
@fisherspy fisherspy merged commit 77c326a into NG-ZORRO:master May 21, 2019
@GeniusLuo
Copy link

非常感谢,加入了'top'和'bottom',可以调节位置!

@nuonuoge nuonuoge deleted the fix-toast branch May 31, 2019 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants