Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: datepicker): fix new Date init in safari would be invlid date. #454

Merged
merged 2 commits into from
May 23, 2019

Conversation

Guoyuanqiang
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #454 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
+ Coverage   85.66%   85.68%   +0.01%     
==========================================
  Files         270      270              
  Lines        7589     7592       +3     
  Branches     1084     1085       +1     
==========================================
+ Hits         6501     6505       +4     
+ Misses        663      660       -3     
- Partials      425      427       +2
Impacted Files Coverage Δ
components/date-picker/date-picker.component.ts 74.24% <0%> (-0.46%) ⬇️
components/picker/picker.component.ts 69.69% <0%> (+1.51%) ⬆️
components/picker/picker.service.ts 85% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3e77c0...5036e6a. Read the comment docs.

@fisherspy fisherspy merged commit 87c62a3 into NG-ZORRO:master May 23, 2019
@Guoyuanqiang Guoyuanqiang deleted the date-pickr branch May 23, 2019 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants