Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: radio-item-group): fix checked error. (#458) #463

Merged
merged 7 commits into from Jun 3, 2019
Merged

fix(module: radio-item-group): fix checked error. (#458) #463

merged 7 commits into from Jun 3, 2019

Conversation

Anberm
Copy link
Contributor

@Anberm Anberm commented Jun 1, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #458

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jun 1, 2019

Codecov Report

Merging #463 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
+ Coverage   85.57%   85.58%   +<.01%     
==========================================
  Files         270      270              
  Lines        7597     7601       +4     
  Branches     1087     1087              
==========================================
+ Hits         6501     6505       +4     
  Misses        671      671              
  Partials      425      425
Impacted Files Coverage Δ
components/radio/radio-item.component.ts 93.75% <100%> (+0.41%) ⬆️
components/radio/radio-item-group.component.ts 81.39% <100%> (+0.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeabc11...6c14bda. Read the comment docs.

@fisherspy fisherspy merged commit 0e3ca04 into NG-ZORRO:master Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants