Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: icon): fix icon line-height(#46) #47

Merged
merged 3 commits into from Oct 15, 2018
Merged

fix(module: icon): fix icon line-height(#46) #47

merged 3 commits into from Oct 15, 2018

Conversation

nuonuoge
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@fisherspy
Copy link
Collaborator

please create an addon.less, and add your modification. because we share the same index.less with react version, so index.less couldn't be modified.

@codecov
Copy link

codecov bot commented Oct 15, 2018

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   85.91%   85.91%           
=======================================
  Files         209      209           
  Lines        6894     6894           
  Branches      978      978           
=======================================
  Hits         5923     5923           
  Misses        559      559           
  Partials      412      412
Impacted Files Coverage Δ
components/icon/icon.component.ts 96% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e6d8c8...704ede9. Read the comment docs.

@fisherspy fisherspy merged commit 28d76f2 into NG-ZORRO:master Oct 15, 2018
@nuonuoge nuonuoge deleted the fix branch October 16, 2018 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants