Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: calendar): update testing coverage #474

Merged
merged 2 commits into from
Jun 18, 2019

Conversation

3fuyu
Copy link
Contributor

@3fuyu 3fuyu commented Jun 18, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@3fuyu 3fuyu requested a review from BronzeCui June 18, 2019 10:01
@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

Merging #474 into master will increase coverage by 1.68%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #474      +/-   ##
==========================================
+ Coverage   85.83%   87.51%   +1.68%     
==========================================
  Files         270      270              
  Lines        7576     7579       +3     
  Branches     1076     1078       +2     
==========================================
+ Hits         6503     6633     +130     
+ Misses        656      530     -126     
+ Partials      417      416       -1
Impacted Files Coverage Δ
...onents/calendar/datepicker/datepicker.component.ts 83.14% <100%> (+24.71%) ⬆️
components/calendar/calendar.component.ts 84.03% <80%> (+12.6%) ⬆️
components/picker/picker.component.ts 69% <0%> (+1.5%) ⬆️
components/calendar/header/header.component.ts 88% <0%> (+4%) ⬆️
components/picker/picker.service.ts 85% <0%> (+5%) ⬆️
.../calendar/confirm-panel/confirm-panel.component.ts 95% <0%> (+10%) ⬆️
...s/calendar/datepicker/datepicker.base.component.ts 85.88% <0%> (+23.92%) ⬆️
...ts/calendar/single-month/single-month.component.ts 93.18% <0%> (+28.4%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51772f7...a6455da. Read the comment docs.

Copy link
Contributor

@BronzeCui BronzeCui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this._delta = event.touches[0].screenY || event.touches[0].pageY - this._lastY;
check this

Copy link
Contributor

@BronzeCui BronzeCui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change title: test(module: calendar).....

@fisherspy fisherspy merged commit 7dd77ba into NG-ZORRO:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants