Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: README): add CodeFactor&Twitter #490

Merged
merged 2 commits into from
Jul 3, 2019

Conversation

fisherspy
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@fisherspy fisherspy requested a review from BronzeCui July 3, 2019 08:33
Copy link
Contributor

@BronzeCui BronzeCui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

Merging #490 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #490      +/-   ##
==========================================
+ Coverage   87.47%   87.52%   +0.05%     
==========================================
  Files         270      270              
  Lines        7584     7584              
  Branches     1082     1082              
==========================================
+ Hits         6634     6638       +4     
+ Misses        536      530       -6     
- Partials      414      416       +2
Impacted Files Coverage Δ
components/picker/picker.component.ts 69% <0%> (+1.5%) ⬆️
components/picker/picker.service.ts 85% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e54fa9...cd34d64. Read the comment docs.

@fisherspy fisherspy merged commit 6fe3caf into NG-ZORRO:master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants