Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:picker): fix okText dismissText api #499

Merged
merged 2 commits into from
Jul 12, 2019
Merged

fix(module:picker): fix okText dismissText api #499

merged 2 commits into from
Jul 12, 2019

Conversation

nuonuoge
Copy link
Collaborator

@nuonuoge nuonuoge commented Jul 8, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #499 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #499   +/-   ##
=======================================
  Coverage   87.52%   87.52%           
=======================================
  Files         270      270           
  Lines        7584     7584           
  Branches     1082     1084    +2     
=======================================
  Hits         6638     6638           
  Misses        530      530           
  Partials      416      416
Impacted Files Coverage Δ
components/picker/picker.component.ts 69% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3febda7...20d4f8b. Read the comment docs.

@Guoyuanqiang Guoyuanqiang merged commit 0c9bc52 into NG-ZORRO:master Jul 12, 2019
@nuonuoge nuonuoge deleted the fix-picker branch August 14, 2019 10:36
fisherspy pushed a commit that referenced this pull request Mar 10, 2020
* fix(module:picker): fix okText dismissText api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants