Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: carousel): update testing coverage #511

Merged
merged 3 commits into from
Jul 29, 2019

Conversation

Guoyuanqiang
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #511 into master will increase coverage by 0.14%.
The diff coverage is 86.2%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #511      +/-   ##
==========================================
+ Coverage   88.38%   88.52%   +0.14%     
==========================================
  Files         269      269              
  Lines        7514     7514              
  Branches     1064     1064              
==========================================
+ Hits         6641     6652      +11     
+ Misses        455      439      -16     
- Partials      418      423       +5
Impacted Files Coverage Δ
components/carousel/carousel.component.ts 71.42% <86.2%> (+5.1%) ⬆️
components/picker/picker.service.ts 80% <0%> (-5%) ⬇️
components/picker/picker.component.ts 67.5% <0%> (-1.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 577d8a2...ada4e6e. Read the comment docs.

@fisherspy fisherspy self-requested a review July 26, 2019 06:49
@fisherspy fisherspy merged commit 7f80c13 into NG-ZORRO:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants