Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: carousel): fix mousemove action when carousel only has tw… #56

Merged
merged 2 commits into from
Oct 19, 2018
Merged

fix(module: carousel): fix mousemove action when carousel only has tw… #56

merged 2 commits into from
Oct 19, 2018

Conversation

nuonuoge
Copy link
Collaborator

…o carouselslide

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Oct 17, 2018

Codecov Report

Merging #56 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage    85.9%   85.92%   +0.02%     
==========================================
  Files         209      209              
  Lines        6897     6894       -3     
  Branches      977      974       -3     
==========================================
- Hits         5925     5924       -1     
  Misses        559      559              
+ Partials      413      411       -2
Impacted Files Coverage Δ
components/carousel/carousel.component.ts 67.53% <ø> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e44ba21...c8ba3d7. Read the comment docs.

@fisherspy fisherspy requested review from 3fuyu and BronzeCui and removed request for Guoyuanqiang and 3fuyu October 18, 2018 09:41
@3fuyu 3fuyu merged commit bc02951 into NG-ZORRO:master Oct 19, 2018
@nuonuoge nuonuoge deleted the fixcarousel branch October 21, 2018 09:47
fisherspy pushed a commit that referenced this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants