Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: carousel): add stopPropagation when touch action is triggered #61

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Conversation

fisherspy
Copy link
Collaborator

…ered

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@fisherspy fisherspy requested a review from 3fuyu October 18, 2018 03:22
@codecov
Copy link

codecov bot commented Oct 18, 2018

Codecov Report

Merging #61 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   85.91%   85.92%   +<.01%     
==========================================
  Files         209      209              
  Lines        6895     6898       +3     
  Branches      978      978              
==========================================
+ Hits         5924     5927       +3     
  Misses        559      559              
  Partials      412      412
Impacted Files Coverage Δ
components/carousel/carousel.component.ts 67.64% <100%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ce2ee0...9d6d8e4. Read the comment docs.

@3fuyu 3fuyu merged commit c44ba59 into NG-ZORRO:master Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants