Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: carousel): fix carouselslide no width when vertical:false #67

Merged
merged 2 commits into from Oct 23, 2018
Merged

Conversation

nuonuoge
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Oct 21, 2018

Codecov Report

Merging #67 into master will increase coverage by 0.35%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   85.92%   86.28%   +0.35%     
==========================================
  Files         209      209              
  Lines        6894     6898       +4     
  Branches      974      974              
==========================================
+ Hits         5924     5952      +28     
+ Misses        559      552       -7     
+ Partials      411      394      -17
Impacted Files Coverage Δ
components/carousel/carousel.component.ts 76.83% <88.88%> (+9.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b46b86...0f99069. Read the comment docs.

@BronzeCui BronzeCui self-requested a review October 22, 2018 02:17
@3fuyu 3fuyu requested a review from BronzeCui October 22, 2018 02:19
@BronzeCui BronzeCui self-requested a review October 22, 2018 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants