Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: date-picker-view): add async data input support #718

Merged
merged 2 commits into from Jul 1, 2020
Merged

fix(module: date-picker-view): add async data input support #718

merged 2 commits into from Jul 1, 2020

Conversation

nuonuoge
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@nuonuoge nuonuoge requested a review from fisherspy June 24, 2020 07:30
@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #718 into master will increase coverage by 0.01%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #718      +/-   ##
==========================================
+ Coverage   87.15%   87.16%   +0.01%     
==========================================
  Files         164      164              
  Lines        6740     6747       +7     
  Branches     1102     1104       +2     
==========================================
+ Hits         5874     5881       +7     
  Misses        421      421              
  Partials      445      445              
Impacted Files Coverage Δ
components/picker-view/picker-view.component.ts 92.50% <87.50%> (+1.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 364d368...30b6d34. Read the comment docs.

@fisherspy fisherspy merged commit f2748f0 into NG-ZORRO:master Jul 1, 2020
@nuonuoge nuonuoge deleted the fix-pickerview branch July 6, 2020 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants