Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: direction error of QRCode #739

Merged
merged 2 commits into from Aug 20, 2020
Merged

fix: direction error of QRCode #739

merged 2 commits into from Aug 20, 2020

Conversation

Eve-Sama
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?
修复了官网二维码介绍的方向错误

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

官网二维码的方向错位了, 之前是向上的popover, 会被导航栏遮挡.

Issue Number: N/A

What is the new behavior?

popover向下, 不会遮挡, 与react那边保持一致.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@Eve-Sama Eve-Sama requested a review from tirelyl August 19, 2020 15:32
@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #739 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #739   +/-   ##
=======================================
  Coverage   87.16%   87.16%           
=======================================
  Files         164      164           
  Lines        6748     6748           
  Branches     1104     1104           
=======================================
  Hits         5882     5882           
  Misses        421      421           
  Partials      445      445           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 274e21d...0d656e6. Read the comment docs.

@fisherspy fisherspy merged commit b014e17 into NG-ZORRO:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants