Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: tabbar): typescript error #753

Merged
merged 1 commit into from Oct 21, 2020
Merged

fix(module: tabbar): typescript error #753

merged 1 commit into from Oct 21, 2020

Conversation

Eve-Sama
Copy link
Collaborator

@Eve-Sama Eve-Sama commented Oct 20, 2020

close #750

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: 750

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@@ -17,8 +17,6 @@ export class TabBarItemComponent extends TabPaneComponent {
@Input()
key: string = '';
@Input()
title: string = '';
@Input()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TabBarItemComponent 继承自 TabPaneComponent
在 TabPaneComponent 中已经有了title的input与get set.
那么 TabBarItemComponent 本身也就有了, 没必要重新声明一次.
本地跑过单测了, 全部成功, 项目也run了, title没出现异常.

@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #753 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #753      +/-   ##
==========================================
- Coverage   86.93%   86.93%   -0.01%     
==========================================
  Files         164      164              
  Lines        6635     6634       -1     
  Branches     1111     1111              
==========================================
- Hits         5768     5767       -1     
  Misses        422      422              
  Partials      445      445              
Impacted Files Coverage Δ
components/tab-bar/tab-bar-item.component.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd29dda...e473554. Read the comment docs.

@fisherspy fisherspy merged commit 42b17e2 into NG-ZORRO:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to compile: 'title' is defined as an accessor... TabPaneComponent
2 participants