Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: toast): called in ngOnInit will report an error #795

Merged
merged 1 commit into from Jun 15, 2021

Conversation

shuizhongxiong
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

在生命周期ngOnInit里面调Toast轻提示会报错ERROR Error: ApplicationRef.tick is called recursively

Issue Number: 640

What is the new behavior?

不再报错

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #795 (2072166) into master (c10877a) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

❗ Current head 2072166 differs from pull request most recent head 11822b6. Consider uploading reports for the commit 11822b6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #795      +/-   ##
==========================================
- Coverage   86.86%   86.86%   -0.01%     
==========================================
  Files         164      164              
  Lines        6679     6682       +3     
  Branches     1116     1117       +1     
==========================================
+ Hits         5802     5804       +2     
- Misses        429      430       +1     
  Partials      448      448              
Impacted Files Coverage Δ
components/toast/toast.service.ts 86.30% <50.00%> (-2.28%) ⬇️
components/date-picker/date-picker.component.ts 75.45% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c10877a...11822b6. Read the comment docs.

@fisherspy fisherspy merged commit 77f36ab into NG-ZORRO:master Jun 15, 2021
@shuizhongxiong shuizhongxiong deleted the fix-toast branch August 27, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants