Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: modal): Modal.operation support maskClosable params #804

Merged
merged 3 commits into from Nov 25, 2021

Conversation

shuizhongxiong
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Modal.operation 不支持点击蒙版关闭弹窗

Issue Number: #799

What is the new behavior?

Modal.operation 支持点击蒙版关闭弹窗

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@shuizhongxiong shuizhongxiong requested review from fisherspy and nuonuoge and removed request for nuonuoge August 27, 2021 08:59
@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #804 (5bc5684) into master (cd5216a) will decrease coverage by 0.15%.
The diff coverage is 54.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #804      +/-   ##
==========================================
- Coverage   86.86%   86.71%   -0.16%     
==========================================
  Files         164      164              
  Lines        6682     6614      -68     
  Branches     1117     1107      -10     
==========================================
- Hits         5804     5735      -69     
+ Misses        430      429       -1     
- Partials      448      450       +2     
Impacted Files Coverage Δ
components/modal/modal.module.ts 100.00% <ø> (ø)
components/modal/modal.service.ts 61.33% <52.94%> (-13.67%) ⬇️
components/modal/modal-options.provider.ts 96.15% <66.66%> (-3.85%) ⬇️
components/date-picker/date-picker.component.ts 74.09% <0.00%> (-1.16%) ⬇️
...s/calendar/datepicker/datepicker.base.component.ts 83.63% <0.00%> (-0.61%) ⬇️
components/core/util/position.ts 81.25% <0.00%> (-0.57%) ⬇️
components/image-picker/image-picker.component.ts 72.00% <0.00%> (-0.23%) ⬇️
components/steps/steps.component.ts 88.67% <0.00%> (-0.21%) ⬇️
components/tabs/tabs.component.ts 87.67% <0.00%> (-0.17%) ⬇️
...ts/calendar/single-month/single-month.component.ts 92.94% <0.00%> (-0.17%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd5216a...5bc5684. Read the comment docs.

@shuizhongxiong shuizhongxiong merged commit 00b9e69 into NG-ZORRO:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants