Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: action-sheet): fix click item will response background click event #98

Merged
merged 1 commit into from
Nov 6, 2018

Conversation

Guoyuanqiang
Copy link
Member

…ick event

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #98 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   86.52%   86.53%   +<.01%     
==========================================
  Files         209      209              
  Lines        6896     6897       +1     
  Branches      970      970              
==========================================
+ Hits         5967     5968       +1     
  Misses        539      539              
  Partials      390      390
Impacted Files Coverage Δ
components/action-sheet/action-sheet.service.ts 86.2% <100%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bcfda5...bcf54ae. Read the comment docs.

@Guoyuanqiang Guoyuanqiang merged commit b24bcbc into NG-ZORRO:master Nov 6, 2018
@Guoyuanqiang Guoyuanqiang deleted the guoyq-fix branch November 7, 2018 08:07
fisherspy pushed a commit that referenced this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants