Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: action-sheet): fix click item without event #99

Merged
merged 3 commits into from Nov 7, 2018
Merged

fix(module: action-sheet): fix click item without event #99

merged 3 commits into from Nov 7, 2018

Conversation

nuonuoge
Copy link
Collaborator

@nuonuoge nuonuoge commented Nov 7, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Nov 7, 2018

Codecov Report

Merging #99 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   86.53%   86.54%   +0.01%     
==========================================
  Files         209      209              
  Lines        6897     6897              
  Branches      970      970              
==========================================
+ Hits         5968     5969       +1     
+ Misses        539      538       -1     
  Partials      390      390
Impacted Files Coverage Δ
components/action-sheet/action-sheet.service.ts 87.93% <0%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b24bcbc...37602eb. Read the comment docs.

@nuonuoge nuonuoge changed the title fix(module: action-sheet): fix destructiveButton without click event fix(module: action-sheet): fix click item without event Nov 7, 2018
@Guoyuanqiang Guoyuanqiang merged commit 1697cda into NG-ZORRO:master Nov 7, 2018
@nuonuoge nuonuoge deleted the fixactionsheet branch December 22, 2018 03:01
fisherspy pushed a commit that referenced this pull request Mar 10, 2020
* fix(module: action-sheet): fix click item without event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants